From: volpol Date: Thu, 23 Aug 2018 17:50:23 +0000 (+0200) Subject: Fixed off-by-one error in pump2gpio logic X-Git-Url: https://git.packet-gain.de/?a=commitdiff_plain;h=db6cd57d66a69d89de041a11e1fa8625aecb5f68;p=bbd.git Fixed off-by-one error in pump2gpio logic --- diff --git a/pump.c b/pump.c index 3f3e3ec..8aceb39 100644 --- a/pump.c +++ b/pump.c @@ -37,8 +37,8 @@ int pump_add(int num){ int res = -1; DPRINT ("pump_idx %d", num); if (num > 0 && num <= NUM_PUMPS){ - int gpio = P2G[num]; - DPRINT ("pump_gpio %d", gpio); + int gpio = P2G[num - 1]; + DPRINT ("pump_gpio %d\n", gpio); setup_gpio(gpio, OUTPUT, PUD_UP); pump_off(num); res = 0; @@ -48,10 +48,10 @@ int pump_add(int num){ int pump_del(int num){ int res = -1; - DPRINT ("pump_idx %d", num); + DPRINT ("pump_idx %d\n", num); if (num > 0 && num <= NUM_PUMPS){ - int gpio = P2G[num]; - DPRINT ("pump_gpio %d", gpio); + int gpio = P2G[num - 1]; + DPRINT ("pump_gpio %d\n", gpio); setup_gpio(gpio, INPUT, PUD_OFF); res = 0; } @@ -59,19 +59,19 @@ int pump_del(int num){ } void pump_on(int num){ - DPRINT ("pump_idx %d", num); + DPRINT ("pump_idx %d\n", num); if (num > 0 && num <= NUM_PUMPS){ - int gpio = P2G[num]; - DPRINT ("pump_gpio %d", gpio); + int gpio = P2G[num - 1]; + DPRINT ("pump_gpio %d\n", gpio); output_gpio(gpio, LOW); } } void pump_off(int num){ - DPRINT ("pump_idx %d", num); + DPRINT ("pump_idx %d\n", num); if (num > 0 && num <= NUM_PUMPS){ - int gpio = P2G[num]; - DPRINT ("pump_gpio %d", gpio); + int gpio = P2G[num - 1]; + DPRINT ("pump_gpio %d\n", gpio); output_gpio(gpio, HIGH); } }