From: Urban Wallasch <urban.wallasch@freenet.de>
Date: Thu, 20 May 2021 10:54:48 +0000 (+0200)
Subject: * Do not clear unused parameters from config.
X-Git-Tag: v0.3~22
X-Git-Url: https://git.packet-gain.de/?a=commitdiff_plain;h=f4c337fc1599911c3ad3ec1cdebea67a3b61060a;p=ffpreview.git

* Do not clear unused parameters from config.
* Only include applicable method parameters in thinfo.
---

diff --git a/ffpreview.py b/ffpreview.py
index 4449069..13d790f 100755
--- a/ffpreview.py
+++ b/ffpreview.py
@@ -289,29 +289,6 @@ def configure():
     if args.manage:
         cfg['manage'] = args.manage
 
-    # clear unused method parameters
-    if cfg['method'] == 'scene':
-        cfg['time_skip'] = None
-        cfg['frame_skip'] = None
-        cfg['customvf'] = None
-    elif cfg['method'] == 'skip':
-        cfg['scene_thresh'] = None
-        cfg['time_skip'] = None
-        cfg['customvf'] = None
-    elif cfg['method'] == 'time':
-        cfg['scene_thresh'] = None
-        cfg['frame_skip'] = None
-        cfg['customvf'] = None
-    elif cfg['method'] == 'customvf':
-        cfg['scene_thresh'] = None
-        cfg['time_skip'] = None
-        cfg['frame_skip'] = None
-    elif cfg['method'] == 'iframe':
-        cfg['scene_thresh'] = None
-        cfg['time_skip'] = None
-        cfg['frame_skip'] = None
-        cfg['customvf'] = None
-
     # parse grid geometry
     grid = re.split('[xX,;:]', cfg['grid'])
     cfg['grid_columns'] = int(grid[0])
@@ -1335,14 +1312,21 @@ def get_thinfo(vfile, thdir):
         'count': 0,
         'width': cfg['thumb_width'],
         'method': cfg['method'],
-        'frame_skip': cfg['frame_skip'],
-        'time_skip': cfg['time_skip'],
-        'scene_thresh': cfg['scene_thresh'],
-        'customvf': cfg['customvf'],
-        'date': 0,
-        'ffpreview': _FFPREVIEW_VERSION,
-        'th': []
     }
+    # include method specific parameters (only)
+    if cfg['method'] == 'scene':
+        thinfo['scene_thresh'] = cfg['scene_thresh']
+    elif cfg['method'] == 'skip':
+        thinfo['frame_skip'] = cfg['frame_skip']
+    elif cfg['method'] == 'time':
+        thinfo['time_skip'] = cfg['time_skip']
+    elif cfg['method'] == 'customvf':
+        thinfo['customvf'] = cfg['customvf']
+    # set these here for neater ordering
+    thinfo['ffpreview'] = _FFPREVIEW_VERSION
+    thinfo['date'] = 0
+    thinfo['th'] = []
+    # get video file meta info (frames, duration, fps)
     meta, ok = get_meta(vfile)
     if not ok:
         return None, False